Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark AbstractSchemaManager::extractDoctrineTypeFromComment() and ::removeDoctrineTypeFromComment() internal #5106

Merged
merged 1 commit into from Dec 11, 2021
Merged

Mark AbstractSchemaManager::extractDoctrineTypeFromComment() and ::removeDoctrineTypeFromComment() internal #5106

merged 1 commit into from Dec 11, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Dec 11, 2021

Q A
Type improvement
BC Break no

These methods won't be publicly accessible in DBAL 4 (see #3501).

@morozov morozov added this to the 3.3.0 milestone Dec 11, 2021
@morozov morozov merged commit 834eb63 into doctrine:3.3.x Dec 11, 2021
@morozov morozov deleted the extract-type-from-comment-internal branch December 11, 2021 15:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
Documentation Schema Management Type Mapping
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@morozov @greg0ire