Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate AbstractPlatform::prefersIdentityColumns() #5119

Merged
merged 1 commit into from Dec 15, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Dec 15, 2021

Q A
Type deprecation
BC Break no

Similar to AbstractPlatform::prefersSequences() deprecated in #4229, AbstractPlatform::prefersIdentityColumns() is not used anywhere and defines a poor abstraction. A platform shouldn't “prefer” anything, it should “do” something in terms of the abstraction it implements.

The ORM doesn't use either of the methods as of doctrine/orm#8870.

@morozov morozov merged commit 9247a4c into doctrine:3.3.x Dec 15, 2021
@morozov morozov deleted the deprecate-prefers-identity-columns branch December 15, 2021 18:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants