Adding the constant PARAM_ASCII_ARRAY to Doctrine\DBAL\Connection
#5120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since I change it to be merged to 3.x version instead of 2.x, I closed the other PR #5115 and opened a new one |
|
Can you look into the failing tests? |
|
Sure., I'm out for holidays now, and will check when I get back |
|
Sure, no pressure. Have a wonderful Christmas! 🎄 |
|
I hope that you folks had great holidays, the test are passing now |
derrabus
changed the title
PARAM_ASCII_ARRAY to Doctrine\DBAL\Connection
This fix enable to use ASCII_STRING as type for Arrays of strings. This new parameter was added in version 2.11.x but unfortunally we don't have a way to use in a array. Also added it in the check for Param array in ExpandArrayParameters.php so we can handle it there too
derrabus
force-pushed
the
adding_ascii_parameter_array_3.x
branch
from
a20b97b
to
f1037f4
Compare
derrabus
approved these changes
Jan 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the constant PARAM_ASCII_ARRAY to Doctrine\DBAL\Connection
This fix enable to use ASCII_STRING as type for Arrays of strings.
This new parameter was added in version 2.11.x but unfortunally we don't have a way to use in a array.
Also added it in the check for Param array in ExpandArrayParameters.php so we can handle it there too
Summary