Use native Oracle 12c syntax for Top-N queries #5150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From https://blogs.oracle.com/pcoe/post/oracle-database-12c-release-1-12102-generally-available this looks like this was released in 2014, which is more than sufficiently long ago to remove the old behavior, but propably worthy a note somewhere that 12c is the minimum supported version now (or is it already due to other things?). |
beberlei
approved these changes
Dec 30, 2021
|
It is mentioned in the upgrade notes (#5114). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3326.
The new syntax is available starting Oracle 12c.
The unit tests around SQL are quite pointless. While they could be easily reworked, I believe it's better to remove them.