Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document $lockMode value range #5157

Merged
merged 1 commit into from Jan 2, 2022
Merged

Document $lockMode value range #5157

merged 1 commit into from Jan 2, 2022

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Jan 2, 2022

Q A
Type improvement
BC Break no
Fixed issues N/A

Summary

This PR narrows down the allowed value range for $lockMode parameters. This way, Psalm and PHPStan can inspect userland code that calls our methods and warn about invalid $lockMode values.

@derrabus derrabus added this to the 3.3.0 milestone Jan 2, 2022
@derrabus derrabus merged commit 70e22a5 into doctrine:3.3.x Jan 2, 2022
@derrabus derrabus deleted the improvement/lockmode branch January 2, 2022 08:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@morozov morozov morozov approved these changes

Assignees
No one assigned
Labels
Static Analysis
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@derrabus @morozov