Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trailing comma in a PDO object parameters #5161

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Remove trailing comma in a PDO object parameters #5161

merged 1 commit into from
Jan 5, 2022

Conversation

mesolaries
Copy link
Contributor

@mesolaries mesolaries commented Jan 5, 2022 •
edited

Q A
Type bug
BC Break yes
Fixed issues #5160

Closes #5160

@mesolaries mesolaries mentioned this pull request Jan 5, 2022
Closed
@greg0ire
Copy link
Member

greg0ire commented Jan 5, 2022 •
edited

Not sure why we are running some jobs on PHP 7.4 instead of 7.3 🤔
I did that in #4310

@derrabus derrabus added this to the 3.2.1 milestone Jan 5, 2022
@derrabus derrabus merged commit 4caf37a into doctrine:3.2.x Jan 5, 2022
@derrabus
Copy link
Member

derrabus commented Jan 5, 2022

Thank you, @mesolaries!

@mesolaries mesolaries deleted the patch-1 branch January 5, 2022 09:15
@mesolaries mesolaries changed the title [PDO Postgresql] Remove trailing comma in a PDO object parameters Remove trailing comma in a PDO object parameters Jan 5, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Bug pdo_pgsql
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

Extra comma in Postgresql driver connection code
3 participants
@mesolaries @greg0ire @derrabus