Json_Array: Convert database null to PHP null instead of empty array #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-828 We use Jira to track the state of pull requests and the versions they got |
|
@localheinz saw this - waiting for @deeky666's opinion first. |
| @@ -55,7 +55,7 @@ public function convertToDatabaseValue($value, AbstractPlatform $platform) | |||
| public function convertToPHPValue($value, AbstractPlatform $platform) | |||
| { | |||
| if ($value === null) { | |||
| return array(); | |||
| return null; | |||
There was a problem hiding this comment.
Not sure if we can change this in 2.x as it surely breaks BC. @beberlei thoughts?
|
To preserve BC we cannot change that in 2.x unfortunately but instead have to address this in 3.0 as @guilhermeblanco pointed out in doctrine/orm#968. |
This was referenced Dec 6, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to doctrine/orm#968.