Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SchemaDiffVisitor #5419

Merged
merged 1 commit into from
May 31, 2022
Merged

Remove SchemaDiffVisitor #5419

merged 1 commit into from
May 31, 2022

Conversation

morozov
Copy link
Member

@morozov morozov commented May 31, 2022 •
edited

This interface is undocumented and hasn't been implemented or used since its introduction in 5eea991. I don't believe it's subject to the regular deprecation process.

@morozov morozov added this to the 3.4.0 milestone May 31, 2022
@morozov morozov requested review from derrabus and greg0ire May 31, 2022 21:22
SenseException
SenseException approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@morozov morozov merged commit 37d18e0 into doctrine:3.4.x May 31, 2022
@morozov morozov deleted the remove-schema-diff-visitor branch May 31, 2022 22:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@SenseException SenseException SenseException approved these changes

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@morozov @greg0ire @SenseException