Rework introspection of table names #5452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
commented
Jun 19, 2022
| @@ -255,7 +263,7 @@ protected function _getPortableTableForeignKeyDefinition($tableForeignKey) | |||
| */ | |||
| protected function _getPortableTableDefinition($table) | |||
| { | |||
| if (isset($table['schema_name']) && $table['schema_name'] !== 'dbo') { | |||
| if ($table['schema_name'] !== 'dbo') { | |||
There was a problem hiding this comment.
The isset() check is redundant since the columns should always be in the result set. Suppressing the notice if it doesn't exist creates a potential for regressions during the refactoring of the schema introspection queries.
| $sql = <<<'SQL' | ||
| SELECT name, | ||
| SCHEMA_NAME(schema_id) AS schema_name | ||
| FROM sys.objects |
There was a problem hiding this comment.
We're moving from sysobjects in SQLServerPlatform to sys.objects here since the former is deprecated.
greg0ire
approved these changes
Jun 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AbstractPlatform::getListTablesSQL()method deprecated in #5268 cannot be removed yet because it's used byAbstractSchemaManager::listTableNames(). Following the same principle as earlier, this patch moves the logic of building schema introspection queries from the platform classes to the schema managers making the queries an internal implementation detail rather than a public API.