Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PostgreSQLSchemaManager::_getPortableSequencesList() #5453

Merged

Conversation

morozov
Copy link
Member

@morozov morozov commented Jun 19, 2022

This code is redundant:

  1. Concatenation of the schema name and the sequence name in a qualified name is already implemented in _getPortableSequenceDefinition():
    if ($sequence['schemaname'] !== 'public') {
    $sequenceName = $sequence['schemaname'] . '.' . $sequence['relname'];
    } else {
    $sequenceName = $sequence['relname'];
    }
  2. Filtering the list according to the configuration is already implemented in listSequences():
    return $this->filterAssetNames($this->_getPortableSequencesList($sequences));

@morozov morozov added this to the 3.4.0 milestone Jun 19, 2022
@morozov morozov marked this pull request as ready for review June 19, 2022 21:09
@morozov morozov merged commit d4d9389 into doctrine:3.4.x Jun 19, 2022
@morozov morozov deleted the remove-postgres-get-portable-sequence-list branch June 19, 2022 21:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants