Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use double quotes for strings containing contractions #5475

Merged
merged 1 commit into from
Jul 3, 2022
Merged

Use double quotes for strings containing contractions #5475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/Functional/StatementTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public function testStatementIsReusableAfterFreeingResult(): void
public function testReuseStatementWithLongerResults(): void
{
if (TestUtil::isDriverOneOf('pdo_oci')) {
self::markTestIncomplete('PDO_OCI doesn\'t support fetching blobs via PDOStatement::fetchAll()');
self::markTestIncomplete("PDO_OCI doesn't support fetching blobs via PDOStatement::fetchAll()");
}

$table = new Table('stmt_longer_results');
Expand Down Expand Up @@ -92,7 +92,7 @@ public function testFetchLongBlob(): void
if (TestUtil::isDriverOneOf('pdo_oci')) {
// inserting BLOBs as streams on Oracle requires Oracle-specific SQL syntax which is currently not supported
// see http://php.net/manual/en/pdo.lobs.php#example-1035
self::markTestSkipped('DBAL doesn\'t support storing LOBs represented as streams using PDO_OCI');
self::markTestSkipped("DBAL doesn't support storing LOBs represented as streams using PDO_OCI");
}

// make sure memory limit is large enough to not cause false positives,
Expand Down
2 changes: 1 addition & 1 deletion tests/Functional/TypeConversionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ public function testIdempotentConversionToString(string $type, $originalValue):
if ($type === 'text' && TestUtil::isDriverOneOf('pdo_oci')) {
// inserting BLOBs as streams on Oracle requires Oracle-specific SQL syntax which is currently not supported
// see http://php.net/manual/en/pdo.lobs.php#example-1035
self::markTestSkipped('DBAL doesn\'t support storing LOBs represented as streams using PDO_OCI');
self::markTestSkipped("DBAL doesn't support storing LOBs represented as streams using PDO_OCI");
}

$dbValue = $this->processValue($type, $originalValue);
Expand Down
2 changes: 1 addition & 1 deletion tests/Functional/Types/BinaryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class BinaryTest extends FunctionalTestCase
protected function setUp(): void
{
if (TestUtil::isDriverOneOf('pdo_oci')) {
self::markTestSkipped('PDO_OCI doesn\'t support binding binary values');
self::markTestSkipped("PDO_OCI doesn't support binding binary values");
}

$table = new Table('binary_table');
Expand Down