Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table schema clone is not needed in SqlitePlatform #5500

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Table schema clone is not needed in SqlitePlatform #5500

merged 1 commit into from
Jul 14, 2022

Conversation

mvorisek
Copy link
Contributor

Q A
Type improvement
Fixed issues n/a

Summary

code cleanup only, clone is not needed

@mvorisek mvorisek marked this pull request as ready for review July 13, 2022 21:29
@SenseException
Copy link
Member

SenseException commented Jul 13, 2022 •
edited

It doesn't seem that state changes happen on table which would need a clone.

@morozov morozov added this to the 3.4.0 milestone Jul 14, 2022
@morozov morozov merged commit dd6c0f9 into doctrine:3.4.x Jul 14, 2022
@mvorisek mvorisek deleted the no_sqlite_plat_diff_clone branch July 14, 2022 16:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SenseException SenseException SenseException approved these changes

Assignees
No one assigned
Labels
Schema Management SQLite
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mvorisek @SenseException @morozov