Deprecate SqlitePlatform::getTinyIntTypeDeclarationSQL() and ::getMediumIntTypeDeclarationSQL() #5511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Jul 16, 2022
src/Platforms/SqlitePlatform.php
Outdated
| * @param array<string, mixed> $column | ||
| * | ||
| * @return string | ||
| */ | ||
| public function getTinyIntTypeDeclarationSQL(array $column) | ||
| { | ||
| Deprecation::trigger( | ||
| 'doctrine/dbal', | ||
| 'https://github.com/doctrine/dbal/pull/TODO', |
There was a problem hiding this comment.
:point_up: :slightly_smiling_face:
…iumIntTypeDeclarationSQL()
morozov
force-pushed
the
deprecate-sqlite-tiny-medium-int
branch
from
0ad82c3
to
3bee5e1
Compare
greg0ire
approved these changes
Jul 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods are implemented only by the SQLite platform, and the column types they implement are not portable across the rest of the supported platforms. The methods are used only in unit tests.