Use assertCount() when possible
#5535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
Jul 25, 2022
| @@ -513,7 +513,7 @@ public function testCreateTableWithForeignKeys(): void | |||
|
|
|||
| $fkTable = $this->schemaManager->listTableDetails('test_create_fk'); | |||
| $fkConstraints = $fkTable->getForeignKeys(); | |||
| self::assertEquals(1, count($fkConstraints), "Table 'test_create_fk1' has to have one foreign key."); | |||
| self::assertCount(1, $fkConstraints, "Table 'test_create_fk' has to have one foreign key."); | |||
mvorisek
approved these changes
Jul 25, 2022
morozov
approved these changes
Jul 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A small improvement for the test suite. We should use
assertCount()instead ofassertEquals($someNumber, count(…)). In case of a failure, we will get a nicer error message this way.