Reduce duplication of collation declaration code #5654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is safe to quote collation in the default implementation of getColumnCollationDeclarationSQL() since those platforms where the case sensitivity of an identifier depends on whether it's quoted (Oracle, IBM DB2) do not support column collation anyways.
morozov
force-pushed
the
collation-declaration-duplication
branch
from
bdc345b
to
832f51a
Compare
SenseException
approved these changes
Sep 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is safe to quote collation in the default implementation of
getColumnCollationDeclarationSQL()since those platforms where the case sensitivity of an identifier depends on whether it's quoted (Oracle, IBM DB2) do not support column collation anyways.SQL Server does not support quoting collation identifiers, so we'll handle it as a special case.