Rework some tests that instantiate TableDiff #5746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
force-pushed
the
rework-table-diff-tests
branch
from
25ed59c
to
186d0a6
Compare
morozov
commented
Oct 11, 2022
Comment on lines
-231
to
-232
| $tableDiff->renamedColumns['comment_float_0'] | ||
| = new Column('comment_double_0', Type::getType('decimal'), ['comment' => 'Double for real!']); |
There was a problem hiding this comment.
The comment in the renamed column diff ('Double for real!') cannot be different from the original column comment ('0') because the comparator would not detect this as a rename.
greg0ire
approved these changes
Oct 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #5714, the diff should be instantiated by the comparator, not by a third party which the tests represent. See the testing guidelines for more details.