Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Table::changeColumn() #5747

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

morozov
Copy link
Member

@morozov morozov commented Oct 11, 2022

Q A
Type deprecation

The Table::addColumn() and Table::dropColumn() methods are named consistently with their corresponding SQL operations: ALTER TABLE t ADD COLUMN and ALTER TABLE t DROP COLUMN. Let's rename Table::changeColumn() to Table::modifyColumn() to make it consistent with ALTER TABLE t MODIFY COLUMN.

@morozov morozov added this to the 3.5.0 milestone Oct 11, 2022
@morozov morozov marked this pull request as ready for review October 11, 2022 15:00
@morozov morozov merged commit 98a8be8 into doctrine:3.5.x Oct 11, 2022
@morozov morozov deleted the deprecate-table-change-column branch October 11, 2022 15:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants