-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3.5 and 4.0 to .doctrine-project.json #5771
Conversation
b5950c3
to
312f806
Compare
{ | ||
"name": "3.4", | ||
"branchName": "3.4.x", | ||
"slug": "latest", | ||
"slug": "current", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does the URL of the latest release documentation need to change? I believe, latest implies latest stable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is consistent with other Doctrine projects (ORM, Persistence, Collections, …) where latest
points to the dev branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot think of a software project outside of the Doctrine organization where latest
would point to a dev branch. As a developer using the library, I most likely don't care about what's in the workings. I care about what I can use now.
This is especially important if the latest documentation is displayed by default or is linked in someone's bookmarks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve as it's consistent with the rest of the projects but I don't believe it's right.
I agree, we should probably discuss the |
Summary
Currently, the documentation for our dev branches in not rendered on the Doctrine website. In order to change that I'm proposing to include information about our dev branches in the .doctrine-project.json file.