Deprecate extension via certain types of events #5785
Conversation
morozov
force-pushed
the
deprecate-schema-ddl-events
branch
from
2f44fbe
to
90da4b3
Compare
morozov
force-pushed
the
deprecate-schema-ddl-events
branch
3 times, most recently
from
635a731
to
732a9f7
Compare
morozov
force-pushed
the
deprecate-schema-ddl-events
branch
from
732a9f7
to
f01e095
Compare
morozov
changed the title
morozov
force-pushed
the
deprecate-schema-ddl-events
branch
from
f01e095
to
4444454
Compare
| $evm->addEventListener($eventNames, new MyEventListener()); | ||
|
|
||
| The following events are available. |
There was a problem hiding this comment.
Do we usually remove docs for things that are deprecated? and if we're doing this, why do we keep the Schema events Section?
There was a problem hiding this comment.
Do we usually remove docs for things that are deprecated?
Not always but I did that recently in #5697 and #5705. The documentation helps users use certain APIs but we don't want them to use them. Furthermore, they may start using a feature because it's documented w/o looking into the implementation or the upgrade docs.
why do we keep the
Schema eventsSection?
My understanding is that besides describing the schema events, this section also describes how one could subscribe to an arbitrary event (which is still technically supported). This document will be entirely removed in a subsequent PR, so I don't think we need to restructure it just before its removal.
See #5784 for the details.
This PR deprecates all events except for
postConnect. Deprecating it (the last remaining one) will require to provide the replacement for its out-of-the-box subscribers:OracleSessionInitandSQLiteSessionInit.