Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing @param tags #589

Merged
merged 1 commit into from Apr 29, 2014
Merged

Add missing @param tags #589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/Doctrine/DBAL/Platforms/OraclePlatform.php
View file
Open in desktop
Expand Up @@ -196,7 +196,7 @@ public function getCreateSequenceSQL(Sequence $sequence)
/**
* {@inheritDoc}
*/
public function getAlterSequenceSQL(\Doctrine\DBAL\Schema\Sequence $sequence)
public function getAlterSequenceSQL(Sequence $sequence)
{
return 'ALTER SEQUENCE ' . $sequence->getQuotedName($this) .
' INCREMENT BY ' . $sequence->getAllocationSize()
Expand All @@ -206,9 +206,11 @@ public function getAlterSequenceSQL(\Doctrine\DBAL\Schema\Sequence $sequence)
/**
* Cache definition for sequences
*
* @param Sequence $sequence
*
* @return string
*/
private function getSequenceCacheSQL(\Doctrine\DBAL\Schema\Sequence $sequence)
private function getSequenceCacheSQL(Sequence $sequence)
{
if ($sequence->getCache() === 0) {
return ' NOCACHE';
Expand Down
11 changes: 7 additions & 4 deletions lib/Doctrine/DBAL/Platforms/PostgreSqlPlatform.php
View file
Open in desktop
Expand Up @@ -22,6 +22,7 @@
use Doctrine\DBAL\Schema\Column;
use Doctrine\DBAL\Schema\ColumnDiff;
use Doctrine\DBAL\Schema\Index;
use Doctrine\DBAL\Schema\Sequence;
use Doctrine\DBAL\Schema\TableDiff;
use Doctrine\DBAL\Types\BinaryType;
use Doctrine\DBAL\Types\BlobType;
Expand Down Expand Up @@ -604,7 +605,7 @@ public function getCommentOnColumnSQL($tableName, $columnName, $comment)
/**
* {@inheritDoc}
*/
public function getCreateSequenceSQL(\Doctrine\DBAL\Schema\Sequence $sequence)
public function getCreateSequenceSQL(Sequence $sequence)
{
return 'CREATE SEQUENCE ' . $sequence->getQuotedName($this) .
' INCREMENT BY ' . $sequence->getAllocationSize() .
Expand All @@ -616,7 +617,7 @@ public function getCreateSequenceSQL(\Doctrine\DBAL\Schema\Sequence $sequence)
/**
* {@inheritDoc}
*/
public function getAlterSequenceSQL(\Doctrine\DBAL\Schema\Sequence $sequence)
public function getAlterSequenceSQL(Sequence $sequence)
{
return 'ALTER SEQUENCE ' . $sequence->getQuotedName($this) .
' INCREMENT BY ' . $sequence->getAllocationSize() .
Expand All @@ -626,9 +627,11 @@ public function getAlterSequenceSQL(\Doctrine\DBAL\Schema\Sequence $sequence)
/**
* Cache definition for sequences
*
* @param Sequence $sequence
*
* @return string
*/
private function getSequenceCacheSQL(\Doctrine\DBAL\Schema\Sequence $sequence)
private function getSequenceCacheSQL(Sequence $sequence)
{
if ($sequence->getCache() > 1) {
return ' CACHE ' . $sequence->getCache();
Expand All @@ -642,7 +645,7 @@ private function getSequenceCacheSQL(\Doctrine\DBAL\Schema\Sequence $sequence)
*/
public function getDropSequenceSQL($sequence)
{
if ($sequence instanceof \Doctrine\DBAL\Schema\Sequence) {
if ($sequence instanceof Sequence) {
$sequence = $sequence->getQuotedName($this);
}
return 'DROP SEQUENCE ' . $sequence . ' CASCADE';
Expand Down