Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SchemaDiff detecting errors in column definition when using custom type in 4.0.x #5988

Merged

Conversation

janedbal
Copy link
Contributor

@janedbal janedbal commented Apr 3, 2023

Q A
Type improvement
Fixed issues 0

Summary

Added test to prove it got fixed in 4.0.x. Original issue.

@derrabus
Copy link
Member

derrabus commented Apr 3, 2023

Thank you.

I think, the issue that is tested here is not specific to MySQL. Can we please move it to a function test that is executed on all platforms (e.g. Doctrine\DBAL\Tests\Functional\Schema\ComparatorTest)?

Also, please run vendor/bin/phpcbf to get rid of the code style issues.

…pe in 4.0.x

Co-authored-by: Alexander M. Turek <me@derrabus.de>
@derrabus derrabus force-pushed the try-column-custom-type-diff-over-v4 branch from 5a2dab7 to 5015338 Compare June 15, 2023 08:56
@derrabus derrabus added this to the 4.0.0-beta3 milestone Jun 15, 2023
@derrabus derrabus merged commit c74c684 into doctrine:4.0.x Jun 15, 2023
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants