[SCA] Minor improvement on Psalm typing #6003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansys
force-pushed
the
sc_1
branch
13 times, most recently
from
6d5392f
to
396e770
Compare
greg0ire
previously approved these changes
Apr 12, 2023
SenseException
requested changes
Apr 12, 2023
src/Driver/SQLite3/Statement.php
Outdated
| /** | ||
| * @throws UnknownParameterType | ||
| * | ||
| * @inheritdoc |
There was a problem hiding this comment.
Suggested change
| * @inheritdoc | |
| * {@inheritdoc} |
There was a problem hiding this comment.
I could make a different PR updating this in the whole repo if you agree. There are much more occurrences.
There was a problem hiding this comment.
It was correct when it was on its own, so it's fine when you're doing it only for the two occurrences of this PR.
src/Driver/SQLite3/Statement.php
Outdated
| /** | ||
| * @throws UnknownParameterType | ||
| * | ||
| * @inheritdoc |
There was a problem hiding this comment.
Suggested change
| * @inheritdoc | |
| * {@inheritdoc} |
SenseException
approved these changes
Apr 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Spin-off from #5998, much less ambitious.