Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use constants for DBAL types in tests #6019

Merged
merged 1 commit into from Apr 19, 2023
Merged

Use constants for DBAL types in tests #6019

merged 1 commit into from Apr 19, 2023

Conversation

phansys
Copy link
Contributor

@phansys phansys commented Apr 19, 2023

Q A
Type improvement
Fixed issues n/a

Summary

The only places where these values were not replaced are the calls to Statement::bindValue() and Statement::bindParam().

Follows #6018.
Related to #5998.

@phansys phansys marked this pull request as ready for review April 19, 2023 14:23
@derrabus derrabus added this to the 3.7.0 milestone Apr 19, 2023
@derrabus derrabus merged commit 4da7e9c into doctrine:3.7.x Apr 19, 2023
72 checks passed
@phansys phansys deleted the type_constants branch April 19, 2023 19:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Test Suite
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phansys @derrabus