New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for unlogged tables in PostgreSQL #6046
Add support for unlogged tables in PostgreSQL #6046
Conversation
Thank you. As always, we need functional tests that prove that your change actually works. Assertions on generated SQL are never sufficient. In this case, the following scenarios must be covered:
|
Since this is a new feature and 3.6.x is closed for features, I'm targeting the 3.7.x branch now. Please rebase your PR onto that branch to make sure you don't run into merge conflicts. |
I think nothing should happen, since the option shouldn't be used by any other db driver |
What's the use case that made you create the PR for adding this new feature? |
I have many Behat tests that read/write data on PostgreSQL DBs and I'd like to run them faster. As I'm using test data, I'm not concerned about possible data corruption in case of crashes. |
Co-authored-by: Alexander M. Turek <me@derrabus.de>
Thank you! |
It was a pleasure! |
Sure, go ahead! |
I'm looking at the docs folder and I'm a bit confused. What docs do yo think I should edit? |
Why's that? |
I don't understand where to put this new information, since I haven't found any part of the documentation regarding the already existing table options for MySQL. |
There a chapter on schema representation. This is where this piece of information fits best, I'd say. But note that…
|
Hi @derrabus , do you already have a planned date for a release containing this feature? Thanks. |
No. But I realize that there are already some features waiting to be released, so I don't want to wait too long either. That being said, you can use the feature already by using a 3.7.x-dev snapshot. |
<!-- Fill in the relevant information below to help triage your pull request. --> | Q | A |------------- | ----------- | Type | improvement | Fixed issues | Add docs for doctrine#6044 #### Summary Add docs for doctrine#6044 / doctrine#6046 --------- Co-authored-by: Alexander M. Turek <me@derrabus.de>
Any news about release dates for this update? |
Summary
Add support for creating unlogged PostgreSQL tables:
https://www.postgresql.org/docs/current/sql-createtable.html
I added a boolean
unlogged
option todefault_table_options
doctrine configurationhttps://www.doctrine-project.org/projects/doctrine-bundle/en/latest/configuration.html
For example: