Make the type annotation for CompositeExpression::count more specific #6188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps static analysis.
derrabus
approved these changes
Oct 15, 2023
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Nov 3, 2023
* 3.8.x: Run tests on MySQL 8.2 (doctrine#6207) MySQLSchemaManager. Check expected database type for json columns only. (doctrine#6189) Make the type annotation for CompositeExpression::count more specific (doctrine#6188)
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Nov 5, 2023
* 3.8.x: Run tests on MySQL 8.2 (doctrine#6207) MySQLSchemaManager. Check expected database type for json columns only. (doctrine#6189) Make the type annotation for CompositeExpression::count more specific (doctrine#6188)
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Nov 5, 2023
* 3.8.x: Generalize CustomIntrospectionTest (doctrine#6210) Run tests on MySQL 8.2 (doctrine#6207) MySQLSchemaManager. Check expected database type for json columns only. (doctrine#6189) Make the type annotation for CompositeExpression::count more specific (doctrine#6188)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps static analysis.
Summary
countcannot return a negative number. Add a PHPDoc annotation to make this clear for static analysis.