Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to absolute paths #6241

Merged
merged 2 commits into from Dec 10, 2023
Merged

Conversation

greg0ire
Copy link
Member

There is a piece of code in doctrine-website that adds leading slash,
and comes with a comment saying to remove that piece of code once all
sidebar files are fixed. It does so only for directories named
"reference", "tutorials" or "cookbook", which might explain why items
under explanation disappear once you navigate deeper in the tree.

See https://github.com/doctrine/doctrine-website/blob/6277d81a78c0d0688012e66f3c2ffd6933e6f63f/lib/Docs/RST/RSTCopier.php#L159-L160

Not sure if that can explain the bug, but let's not take any chances.
There is a piece of code in doctrine-website that adds leading slash,
and comes with a comment saying to remove that piece of code once all
sidebar files are fixed. It does so only for directories named
"reference", "tutorials" or "cookbook", which might explain why items
under explanation disappear once you navigate deeper in the tree.
@derrabus derrabus added this to the 3.7.3 milestone Dec 10, 2023
@greg0ire greg0ire merged commit 6a793fb into doctrine:3.7.x Dec 10, 2023
@greg0ire greg0ire deleted the add-leading-slash branch December 10, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants