fix: sort query parameters by default

[drupol]

Q	A
Type	bug
Fixed issues	Related to symfony/symfony#54172

Summary

Fixing the file //OCI8//ConvertPositionalToNamedParameters.php was enough for our use case, and I confirm that our query is correctly executed now. I also confirm that the initial PR is now optional (symfony/symfony#54172), however I think it's a nice to have. Dealing with named parameters is safer and easier to reason about when reading the code.
I took the liberty to also sort other methods, let me know if I did well or not.

Last question, what's the policy to backport this fix in older versions?

[derrabus]

Thank you. Please provide a functional test that reproduces the issue you're trying to fix.

[derrabus]

Last question, what's the policy to backport this fix in older versions?

We fix bugs on the oldest supported version that is affected by the bug and then merge up from there. That means, if your bug is reproducible on 3.8.x, please retarget your PR.

[derrabus]

It's reproducible from version 2 😞

Which is why I said, "the oldest supported version". That is 3.8 at the moment.

[drupol]

Setting the PR to draft, currently unable to make a reproducer in the tests.

[drupol]

Hey all,

I wanted to provide an update.

After further investigation and numerous attempts to reproduce the issue, including starting from a blank application state and trying to replicate the conditions under which the issue was initially observed, my colleague and I have come to a conclusion that we are now unable to reproduce the issue in any form. Perhaps, this indicates that the problem may have been influenced by factors or states within our specific project setup that we could not accurately replicate in isolated testing, but as of today, we are totally unable to reproduce it.

Given this, this PR is now obsolete, and I'm closing it.

Thanks.