Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AbstractSchemaManager covariant to its template argument #6334

Open
wants to merge 1 commit into
base: 4.0.x
Choose a base branch
from

Conversation

zerkms
Copy link

@zerkms zerkms commented Mar 13, 2024

Q A
Type bug
Fixed issues

Summary

<?php
declare(strict_types=1);

abstract class AbstractPlatform {}

class PostgreSQLPlatform extends AbstractPlatform {}

/**
 * @template T of AbstractPlatform
 */
abstract class AbstractSchemaManager {}

/**
 * @extends AbstractSchemaManager<PostgreSQLPlatform>
 */
class PostgreSQLSchemaManager extends AbstractSchemaManager {}

function createSchemaManager(): AbstractSchemaManager
{
    return new PostgreSQLSchemaManager();
}

$schemaManager = createSchemaManager();

if (!$schemaManager instanceof PostgreSQLSchemaManager) {}
ERROR: [RedundantCondition](https://psalm.dev/122) - 25:6 - AbstractSchemaManager<AbstractPlatform> cannot be identical to PostgreSQLSchemaManager

vs

<?php
declare(strict_types=1);

abstract class AbstractPlatform {}

class PostgreSQLPlatform extends AbstractPlatform {}

/**
 * @template-covariant T of AbstractPlatform
 */
abstract class AbstractSchemaManager {}

/**
 * @extends AbstractSchemaManager<PostgreSQLPlatform>
 */
class PostgreSQLSchemaManager extends AbstractSchemaManager {}

function createSchemaManager(): AbstractSchemaManager
{
    return new PostgreSQLSchemaManager();
}

$schemaManager = createSchemaManager();

if (!$schemaManager instanceof PostgreSQLSchemaManager) {}
No issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant