fix(PgSQL): Allow to pass IPv6 address in URI notation for postgres #6344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR. Please note that we don't merge code changes that are not covered by tests. Is the 3.8.x branch also affected by this bug? If so, please target the 3.8.x branch. |
susnux
force-pushed
the
fix/postgres-ipv6-connection
branch
2 times, most recently
from
9159548
to
2f9e58c
Compare
I have added a test now.
Yes, changed the target. |
susnux
force-pushed
the
fix/postgres-ipv6-connection
branch
from
2f9e58c
to
b96a51d
Compare
|
The Psalm failure is related to your changes. |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/postgres-ipv6-connection
branch
from
b96a51d
to
2360331
Compare
Should be fixed now |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow to pass IPv6 address of postgres server in URI notation (
[ff:aa:...]).When the host is passed in URI format to
hostparameter ofpg_connectit will fail because it then tries to resolve it as when it was a real host name.Instead just pass the IP address to the
hostaddrparameter.