Document how to run integration tests locally #6355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I forgot to remove it in e7aef4e.
greg0ire
commented
Apr 10, 2024
| <var name="tmpdb_port" value="3306"/> | ||
| <var name="tmpdb_user" value="root" /> | ||
| <var name="tmpdb_password" value="" /> | ||
| <var name="tmpdb_dbname" value="doctrine_tests_tmp" /> |
There was a problem hiding this comment.
Another reason for this removal is a discussion with @alli83 about how to run the test suite, where I recommended either using a CI file or these instructions. She reported that the latter did not work (and the former works 🙂 ).
derrabus
previously approved these changes
Apr 10, 2024
greg0ire
force-pushed
the
doc-local-tests
branch
from
79804c9
to
c21ad41
Compare
|
@derrabus if I'm honest, using Docker is exactly how I would do it, so I think it's fair to recommend it indeed. I also removed a previous sentence that felt out of place and replaced it with another one about versions. |
derrabus
reviewed
Apr 10, 2024
greg0ire
force-pushed
the
doc-local-tests
branch
from
c21ad41
to
82d3920
Compare
SenseException
previously approved these changes
Apr 10, 2024
derrabus
reviewed
Apr 11, 2024
docs/en/reference/testing.rst
Outdated
| server, but we do recommend Docker as a convenient way to do so. | ||
| We do not recommend running against a particular version of the chosen | ||
| RDBMS either, as long as you pick one of the `officially supported versions | ||
| <https://www.doctrine-project.org/projects/doctrine-dbal/en/4.0/reference/platforms.html>`_. |
There was a problem hiding this comment.
Shouldn't this be an internal link that should be resolved during rendering?
I am also replacing the commented out connection parameters in phpunit.xml.dist with a link to this paragraph because they have diverged from the one we use in the CI since f88dc28.
greg0ire
force-pushed
the
doc-local-tests
branch
from
82d3920
to
d5d4ed5
Compare
derrabus
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am also replacing the commented out connection parameters in
phpunit.xml.dist with a link to this paragraph because they have
diverged from the one we use in the CI since #4067.