Properly handle MySQL error code 4031 from PHP 8.4 #6363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to target the 3.8.x branch with this change. Did I understand this correctly: we need the change in PHP which has not been merged yet? |
|
@derrabus ok I will update the PR to target 3.8. Basically the change had been merged from PHP 8.2 up, but it was breaking DBAL properly recognising the connection being lost. As it is a BC-breaking change, it has been reverted and it will be soon merged to master only. |
It has been introduced in: mysql/mysql-server@14508bb And PHP 8.4 will support it: php/php-src#13618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PHP 8.4 will support a new error code 4031 in mysqlnd when the connection is dropped due to timeouts.
It has been introduced in:
mysql/mysql-server@14508bb
And PHP 8.4 will support it:
php/php-src#13618
The PR gets the test suite green again (mysqli + pdo_mysql). I have used 4.0.x as base, but feel free to change according to your preferences.