feat: add support for function as default value #6441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
requested changes
Jun 19, 2024
|
Also, please keep in mind that we only allow bugfixes on the 3.8.x branch. Your change however adds new functionality. For that, please target 4.1.x. |
vencakrecl
force-pushed
the
default-value
branch
6 times, most recently
from
d61d985
to
24a2b4a
Compare
vencakrecl
force-pushed
the
default-value
branch
2 times, most recently
from
6e4e4ea
to
fee7382
Compare
|
Schema comparison is still not covered. |
derrabus
requested changes
Jul 8, 2024
Comment on lines
+58
to
+62
| self::assertTrue( | ||
| $sm->createComparator() | ||
| ->compareTables($table, $onlineTable) | ||
| ->isEmpty(), | ||
| ); |
There was a problem hiding this comment.
This is good! Now, what happens if the introspected table…
- … has no default?
- … has a literal value as default?
- … has
NULLas default? - … has a different expression as default?
In that case, we would expect the schema manager to execute the proper SQL to migrate the deployed table and we need to verify that this migration performed successfully.
This has to be covered with tests as well.
Sames goes for the opposite direction: The schema deployed to the database has a column with a default expression and we want to change that to a literal, NULL, no default or a different expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added support for function as default value, for example
id UUID NOT NULL DEFAULT gen_random_uuid()