Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.6 (dev-master at present) excludes all stable versions of symfony/yaml #6639

Closed
asgrim opened this issue Aug 22, 2017 · 6 comments
Closed
Assignees
Labels
Milestone

Comments

@asgrim
Copy link
Contributor

asgrim commented Aug 22, 2017

Latest version is not installable at the moment without explicitly allowing the dev version of symfony/yaml because it's not stable yet. This may have impact on the imminent release of ORM 2.6.

@asgrim
Copy link
Contributor Author

asgrim commented Aug 22, 2017

The cause is the conflict with any version less than 3.4, introduced in 4051547

@Ocramius
Copy link
Member

This is hilarious: we finally managed to remove Yaml support 😂

@stof
Copy link
Member

stof commented Aug 22, 2017

actually, I would remove the usage of the constant without bumping the min version. This constant was added in symfony/yaml 3.3 (so undefined constant also applies to 3.2 and older in the old code of https://github.com/doctrine/doctrine2/pull/6630/files btw) to add a way to force evaluating keys as string to go toward more compliant parsing by default. Just after the release of 3.3 (so too late to revert the introduction of the constant without going through deprecation), we figured out a better upgrade for users to do (and even 3.3 deprecation warnings suggest the better way now instead of suggesting the constant IIRC): actually putting quotes around the key when the unquoted value would not be a YAML string.

And this means that your code is actually working with any version of the Yaml component (you now have again the same code in your driver than in the Symfony 3.2 time). The bump of the min version was a mistake in #6630 due to a bad analysis of when the constant was available.

@Ocramius
Copy link
Member

@stof if that's alright, I'll just remove the conflict then.

Still, had a good and loud laugh :D

@Ocramius Ocramius added the Bug label Aug 22, 2017
@Ocramius Ocramius added this to the 2.6.0 milestone Aug 22, 2017
@Ocramius Ocramius self-assigned this Aug 22, 2017
@stof
Copy link
Member

stof commented Aug 22, 2017

@Ocramius yes, reverting the conflict rule is what you need here.

Too bad that we came up with this PARSE_KEYS_AS_STRINGS feature and released it before finding the right change to do (it's actually not the first time this happened to us. We had this in Symfony 2.3 adding synchronized services in the DIC to support better the request service, and the RequestStack idea was stuck in discussion while releasing it and so came in 2.4 only and synchronized services became useless... Nobody's perfect).

Majkl578 added a commit to Majkl578/doctrine-orm that referenced this issue Aug 30, 2017
As per discussion in doctrine#6639, conflict with versions below 3.4
of the YAML component are superfluous, previous versions
would work just fine even with bb994b9.
@Majkl578
Copy link
Contributor

See #6658.

Majkl578 added a commit to Majkl578/doctrine-orm that referenced this issue Aug 30, 2017
As per discussion in doctrine#6639, conflict with versions below 3.4
of the YAML component is superfluous, previous versions
would work just fine even with bb994b9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants