-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.6 (dev-master at present) excludes all stable versions of symfony/yaml #6639
Comments
The cause is the |
This is hilarious: we finally managed to remove Yaml support 😂 |
actually, I would remove the usage of the constant without bumping the min version. This constant was added in symfony/yaml 3.3 (so undefined constant also applies to 3.2 and older in the old code of https://github.com/doctrine/doctrine2/pull/6630/files btw) to add a way to force evaluating keys as string to go toward more compliant parsing by default. Just after the release of 3.3 (so too late to revert the introduction of the constant without going through deprecation), we figured out a better upgrade for users to do (and even 3.3 deprecation warnings suggest the better way now instead of suggesting the constant IIRC): actually putting quotes around the key when the unquoted value would not be a YAML string. And this means that your code is actually working with any version of the Yaml component (you now have again the same code in your driver than in the Symfony 3.2 time). The bump of the min version was a mistake in #6630 due to a bad analysis of when the constant was available. |
@stof if that's alright, I'll just remove the Still, had a good and loud laugh :D |
@Ocramius yes, reverting the conflict rule is what you need here. Too bad that we came up with this |
As per discussion in doctrine#6639, conflict with versions below 3.4 of the YAML component are superfluous, previous versions would work just fine even with bb994b9.
See #6658. |
As per discussion in doctrine#6639, conflict with versions below 3.4 of the YAML component is superfluous, previous versions would work just fine even with bb994b9.
Latest version is not installable at the moment without explicitly allowing the dev version of symfony/yaml because it's not stable yet. This may have impact on the imminent release of ORM 2.6.
The text was updated successfully, but these errors were encountered: