Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move yaml from require to dev-require #573

Closed
prisis opened this issue Nov 20, 2017 · 3 comments
Closed

Move yaml from require to dev-require #573

prisis opened this issue Nov 20, 2017 · 3 comments

Comments

@prisis
Copy link

prisis commented Nov 20, 2017 •
edited

Are you okay if i make a pr to change the yaml requirement to a optional on?

Not everyone use yaml for configuration.
@mikeSimonson
Copy link
Contributor

I am not to sure how to deal with that kind of optional dependency. I will look at what the options are.

@prisis
Copy link
Author

prisis commented Nov 21, 2017

Only some if checks missing, a composer suggestion and a doc info about how to add yaml back; is a simple composer req.

@chrisguitarguy
Copy link
Contributor

Probably throwing a nice exception indicating that symfony/yaml has to be installed in YamlConfiguration too. Here's an example in symfony.

chrisguitarguy added a commit to chrisguitarguy/migrations that referenced this issue Dec 25, 2017
@chrisguitarguy
Move symfony/yaml into Dev Requirements
60b9a80 
And throw an exception in YamlConfiguration::doLoad if yaml isn't
available.

This also includes a composer suggestion to install symfony/yaml.

Closes doctrine#573
@chrisguitarguy chrisguitarguy mentioned this issue Dec 25, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mikeSimonson @chrisguitarguy @prisis