Move symfony/yaml into Dev Requirements #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And throw an exception in YamlConfiguration::doLoad if yaml isn't available. This also includes a composer suggestion to install symfony/yaml. Closes doctrine#573
alcaeus
approved these changes
Dec 25, 2017
|
Looks good. Tests are pretty much impossible for this one since we test with dev dependencies on travis-ci. Thanks @chrisguitarguy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And throw an exception in YamlConfiguration::doLoad if yaml isn't
available.
This also includes a composer suggestion to install symfony/yaml.
Closes #573
Really not sure how to add a test to cover this. Symfony uses this strategy, but doesn't seem to test it.