-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put doctrine-migrations into including project's vendor/bin directory #311
Conversation
Thanks @dotEvan . Don't we need to set as executable only the doctrine-migrations file and not the php one ? |
}, | ||
"bin": [ | ||
"bin/doctrine-migrations", | ||
"bin/doctrine-migrations.php" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bin/doctrine-migrations.php
should not be there. Only the actual bin is needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stof To be honest, I only use the version without the .php. However, I was being consistent with the way this was done in https://github.com/doctrine/doctrine2/blob/master/composer.json
I didn't want to assume that people didn't also want to be able to do
php ./vendor/bin/doctrine-migrations.php
if they wanted to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this is a mistake in the ORM (it was reverted in DBAL but I missed the fact that the ORM included it too)
@mikeSimonson all files listed in the |
+1 |
@dotEvan Can you make that change in your PR ? Revert the change of permission on bin/doctrine-migrations.php and remove bin/doctrine-migrations.php from the bin section of the composer.json ? |
@mikeSimonson Done. |
Put doctrine-migrations into including project's vendor/bin directory
@dotEvan Thanks |
Enables a project to include doctrine/migrations and then to run any migration commands by running
from the main project's directory.