Support PDO::PARAM_* & Connection::PARAM_* in SQL Output #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the DBAL type system as a fallback when it can, and otherwise runs the value through `json_encode` and hopes for the best. The reasoning here is that on a dry or actual run shouldn't fail because migrations doesn't know how to output a type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the DBAL type system as a fallback when it can, and otherwise
runs the value through
json_encodeand hopes for the best. Thereasoning here is that on a dry or actual run shouldn't fail because
migrations doesn't know how to output a type.
Fixes #528
I'm not 100% on this solution. Not sure if falling back to a DBAL type is a good idea -- maybe we should just
(string) $valuein those cases?