Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin/ entrypoint refresh #717

Merged
merged 2 commits into from
Jun 4, 2018
Merged

bin/ entrypoint refresh #717

merged 2 commits into from
Jun 4, 2018

Conversation

Majkl578
Copy link
Contributor

@Majkl578 Majkl578 commented Jun 4, 2018

Q A
Type improvement
BC Break yes-ish (non-zero exit code)

Summary

Update bin/ to our CS, add namespace and clean up some statements.
Legacy symfony/console fallback removed.
Also exit code 1 is now used in case of error.

Review each commit separately or with ?w=1 to avoid noisy whitespace changes.

@Majkl578 Majkl578 added this to the 2.0 milestone Jun 4, 2018
@Majkl578 Majkl578 requested a review from jwage June 4, 2018 13:25
@jwage jwage merged commit 08aba2a into doctrine:master Jun 4, 2018
@Majkl578 Majkl578 deleted the bin-refresh branch June 4, 2018 15:01
@jwage jwage removed the BC Break label Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants