Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle migrated versions metadata table auto-update #878

Merged
merged 2 commits into from
Jan 3, 2020

Conversation

goetas
Copy link
Member

@goetas goetas commented Dec 1, 2019

Q A
Type feature
BC Break no
Fixed issues #788 #828

Summary

This PR:

  • adds a command migrations:sync-metadata-storage that ensure the table scheme doctrine_migrations is always up to date
  • auto-migrates the v2 table structure to the v3 table structure
  • each command before starting checks if the metadata table is up to date

The Allow phpunit 7.5 commit should be removed when #879 will be merged

@goetas
Copy link
Member Author

goetas commented Dec 1, 2019

@jwage From the git history, in 2.x you have implemented the https://github.com/doctrine/migrations/tree/2.2.x/lib/Doctrine/Migrations/Tracking feature, that was supposed to do something similar as this PR. Do you have time to review this please?

@goetas goetas added this to the 3.0.0 milestone Dec 1, 2019
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prevent accidental merge, dismiss when second commit is removed

@greg0ire
Copy link
Member

greg0ire commented Dec 1, 2019

I think something went wrong with your last push, can you please check? None of my comments are addressed now…

@goetas
Copy link
Member Author

goetas commented Dec 1, 2019

@greg0ire my bad I forgot to pull the changes done via github UI.

@goetas
Copy link
Member Author

goetas commented Dec 6, 2019

Since this feature is quite critical, can somebody else review/test it please?

@alcaeus
Copy link
Member

alcaeus commented Dec 6, 2019

@goetas I don't have any projects using migrations, and other people might be wondering this too: what would be the best way to test this?

@goetas
Copy link
Member Author

goetas commented Dec 6, 2019

The best way to test this is to have a project using migrations 2.x, try the upgrade process to 3.x as described in https://github.com/doctrine/migrations/blob/master/UPGRADE.md, and share the results.

@goetas goetas merged commit ab7ebf3 into doctrine:master Jan 3, 2020
@goetas goetas deleted the auto-update-schema branch January 3, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants