Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableMetadataStorage uses the repository to provide migrations for ta… #929

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

goetas
Copy link
Member

@goetas goetas commented Feb 9, 2020

…ble schema

Q A
Type bug
BC Break yes/no
Fixed issues

Summary

without this dependency, the migration of the table structure from v2 to w3 wont work

@goetas goetas added the Bug label Feb 9, 2020
@greg0ire
Copy link
Member

Not super important for this PR, but please try to make commit that follow the rules in the contributing guide.

For instance, it's good to avoid having the PR title/commit message subject split into 2 with , and it's really great to include useful explanations such as "without this dependency, the migration of the table structure from v2 to w3 wont work" directly in the body of the commit message, that way the changes can be understood without browsing Github.

@goetas
Copy link
Member Author

goetas commented Feb 13, 2020

Not super important for this PR, but please try to make commit that follow the rules in the contributing guide.
For instance, it's good to avoid having the PR title/commit message subject split into 2 with …, and it's really great to include useful explanations such as "without this dependency, the migration of the table structure from v2 to w3 wont work" directly in the body of the commit message, that way the changes can be understood without browsing Github.

Thanks for the feedback, will try to make it better next time!

@goetas goetas merged commit 614715f into doctrine:master Feb 13, 2020
@goetas goetas added this to the 3.0.0 milestone Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants