This repository has been archived by the owner on Nov 11, 2020. It is now read-only.
Include all cursor methods in cursor interface #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| /** | ||
| * Return the connection for this cursor. | ||
| * | ||
| * @deprecated 1.1 Will be removed for 2.0 |
There was a problem hiding this comment.
If this is deprecated, so we really want to add it to the interface?
There was a problem hiding this comment.
I was thinking no, until I saw that ODM\Cursor exposes the method as well (where I wanted to use the same interface). If we leave it out of ODM we can remove it from the interface here, otherwise I'd leave it in. What's your opinion on this?
There was a problem hiding this comment.
As discussed, we can remove this from the interface and have ODM still provide the method in its Cursor class, but simply do $this->baseBursor->getCollection()->getDatabase()->getConnection();
alcaeus
force-pushed
the
extend-cursor-interface
branch
from
c1d44c3
to
8eb2629
Compare
|
LGTM with the interface revisions. |
alcaeus
force-pushed
the
extend-cursor-interface
branch
from
8eb2629
to
23f1b27
Compare
jmikola
force-pushed
the
extend-cursor-interface
branch
2 times, most recently
from
1f92bc8
to
2fc6120
Compare
This replaces a $useKeys constructor option for EagerCursor, allowing it to better support a wrapped CursorInterface. Additionally, we deprecate the Cursor::toArray() $useKeys argument. If omitted, toArray() will default to the Cursor's class option; otherwise, an explicit $useKeys argument may still override.
jmikola
force-pushed
the
extend-cursor-interface
branch
from
8259e8d
to
6f82cd4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the common cursor interface introduced in #209 to include all methods currently available in the cursor. This makes the
CursorandEagerCursormore interchangeable in ODM, allowing us to plug both classes intoODM\Cursoronce that has been adapted.The
hasNextandgetNextmethods have to be simulated by advancing and rewinding the array pointer as well as checking if the cursor has started iterating.