Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't define Doctrine annotations as a hard dependency? #8785

Closed
javiereguiluz opened this issue Jun 25, 2021 · 1 comment
Closed

Don't define Doctrine annotations as a hard dependency? #8785

javiereguiluz opened this issue Jun 25, 2021 · 1 comment

Comments

@javiereguiluz
Copy link
Contributor

In #8266 @beberlei added support for defining mapping with PHP attributes. However, doctrine/annotations is still defined as a required dependency of this project:

orm/composer.json

Line 22 in f233e4c

"doctrine/annotations": "^1.13",

Is there any technical reason to keep it as is, or is it just that we need to find someone willing to contribute this change? Thanks!
@javiereguiluz javiereguiluz mentioned this issue Jun 25, 2021
Closed
@alcaeus
Copy link
Member

alcaeus commented Jun 25, 2021

There is no hard requirement with attributes, and there shouldn't have been one in the first place. I believe a solution as implemented in doctrine/persistence#197 would make sense here.

greg0ire added a commit to greg0ire/doctrine-orm that referenced this issue Jun 25, 2021
@greg0ire
Make doctrine/annotations an optional dependency
9665a68 
First, there are other drivers than the annotations-based one, and
second, one of them is base on attributes, which are basically
annotations native to PHP.

Closes doctrine#8785
@greg0ire greg0ire mentioned this issue Jun 25, 2021
Merged
greg0ire added a commit to greg0ire/doctrine-orm that referenced this issue Jun 26, 2021
@greg0ire
Make doctrine/annotations an optional dependency
fa583f6 
First, there are other drivers than the annotations-based one, and
second, one of them is base on attributes, which are basically
annotations native to PHP.

Closes doctrine#8785
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@javiereguiluz @alcaeus @greg0ire