-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark doctrine/annotations dependency as optional #197
Mark doctrine/annotations dependency as optional #197
Conversation
Cc @javiereguiluz 🙂 |
Now that the ORM has a driver based on PHP attributes, it seems less necessary to require doctrine/annotations. In fact, that could also be considered true before since there are already other drivers than the annotation driver. Fixes doctrine#195
1fe2328
to
52ab59d
Compare
add doctrine/annotations as required dependency see doctrine/persistence#197
add doctrine/annotations as required dependency see doctrine/persistence#197
add doctrine/annotations as required dependency see doctrine/persistence#197
add doctrine/annotations as required dependency see doctrine/persistence#197
If we upgrade from 2.2.4 to 2.3.0, Here is how I fixed that issue in one project: https://github.com/liip/LiipTestFixturesBundle/pull/170/files |
If your project relies on Doctrine Annotations for metadata mapping, adding the explicit dependency is the way to go. |
Related: doctrine/orm#9452 |
Thanks, so I wonder how Update: my bad, it's a |
A |
I'll have to investigate on Symfony's side, but I ended up with a |
Yes. If the library is missing, Symfony won't create that service. But let's not flood this PR with chat messages. Feel free to open a discussion on either board, if you have further questions: |
Now that the ORM has a driver based on PHP attributes, it seems less
necessary to require doctrine/annotations. In fact, that could also be
considered true before since there are already other drivers than the
annotation driver.
Fixes #195