Public readonly properties are unset in Proxy's constructor

[solcik]

Bug Report

Q	A
BC Break	no
Version	2.11.0

• Public readonly properties are unset in Proxy's constructor #9431
• Public readonly properties are unset in Proxy's constructor #9432

Summary

Public readonly properties are unset in Proxy's constructor, which results in error.

Current behavior

Cannot unset readonly property \Entity\SimpleBook::$title from scope Proxies\__CG__\Entity\SimpleBook

How to reproduce

#[Entity, Table]
class SimpleBook
{
    #[Column, Id, GeneratedValue]
    private readonly int $id;

    #[Column]
    public readonly string $title;

    #[ManyToOne, JoinColumn(nullable: false)]
    private readonly Author $author;

    public function getId(): int
    {
        return $this->id;
    }

    public function getTitle(): string
    {
        return $this->title;
    }

    public function getAuthor(): Author
    {
        return $this->author;
    }
}

class SimpleBook extends \Entity\SimpleBook implements \Doctrine\ORM\Proxy\Proxy
{
    // ...

    public function __construct(?\Closure $initializer = null, ?\Closure $cloner = null)
    {
        unset($this->title);

        $this->__initializer__ = $initializer;
        $this->__cloner__      = $cloner;
    }
}

Expected behavior

Code that generates Proxy's constructor

I dug into ProxyGenerator and here is generation of these unsets:

• https://github.com/doctrine/common/blob/3.2.x/lib/Doctrine/Common/Proxy/ProxyGenerator.php#L979

public readonly properties are not tested as I see in tests.

• https://github.com/doctrine/common/blob/3.2.x/tests/Doctrine/Tests/Common/Proxy/ProxyGeneratorTest.php#L481

[acelaya]

I'm experiencing the same. Are readonly properties even supported in entities? 🤔

[kiler129]

Are readonly properties even supported in entities? 🤔

According to the docs at https://www.doctrine-project.org/projects/doctrine-orm/en/2.14/reference/architecture.html#entities - yes, as it says (emphasis mine):

An entity class must not be final nor read-only but it may contain final methods or read-only properties.

[acelaya]

Apparently the problem is only with public readonly properties. If they are private, it's fine.

See #9431 (comment)

[greg0ire]

Are you using a recent version of Doctrine and Symfony? Since #10187 it's possible to use something else than doctrine/common (symfony/var-dumper). Not saying it will fix your issue, but who knows…

[acelaya]

Aha! Worth giving it a try. I'll let you know how it goes

[kiler129]

@greg0ire & @acelaya:

I just tried and... it fails ;) The generated constructor looks like this:

    public function __construct(?\Closure $initializer = null, ?\Closure $cloner = null)
    {
        unset($this->infoPrompt, $this->rulesPrompt);

        $this->__initializer__ = $initializer;
        $this->__cloner__      = $cloner;
    }

Which leads to:

In __CG__AppEntityFacilityLocationCheckInConfiguration.php line 54:
                                                                                                                                                                           
  [Error]                                                                                                                                                                  
  Cannot unset readonly property App\Entity\Facility\LocationCheckInConfiguration::$infoPrompt from scope Proxies\__CG__\App\Entity\Facility\LocationCheckInConfiguration  

The project is pretty new:

% composer show symfony/var-exporter | grep versions
versions : * v6.2.3
% composer show doctrine/orm | grep versions        
versions : * 2.14.0

[acelaya]

@greg0ire it works!

@kiler129 it looks like you forgot to set $config->setLazyGhostObjectEnabled(true), because that looks very much like the old kind of proxy. New ones generated with symfony/var-exporter look nothing like that.