Use Rector to migrate to the object API of FieldMapping #10617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SenseException
requested changes
Apr 11, 2023
Comment on lines
507
to
508
| self::assertNotNull($class->fieldMappings['id']->type); | ||
| self::assertNotNull($class->fieldMappings['name']->type); |
There was a problem hiding this comment.
Do we need those at this point? It's not an array anymore and if type isn't initialized, we would get a "must not be accessed before initialization" (but afaik the props are initialized by default). Nevertheless, the actual value is checked in the next lines. Same with the other assertNotNull methods below.
This makes the array access implementation of FieldMapping useful only to consumers, it is no longer useful internally, and should be deprecated as of Doctrine 3.1.0
greg0ire
force-pushed
the
field-mapping-object-api
branch
from
502583b
to
2acb298
Compare
derrabus
approved these changes
Apr 13, 2023
SenseException
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the array access implementation of FieldMapping useful only to consumers, it is no longer useful internally, and should be deprecated as of Doctrine 3.1.0