Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #10715 - Incorrect subclasses dependencies weight while calculating commit orders #10716

Closed
wants to merge 1 commit into from

Conversation

sylfabre
Copy link
Contributor

This PR fixes #10715

It makes UnitOfWork::getCommitOrder() use consistent weight for both the parent class and subclasses' dependencies

@sylfabre
Copy link
Contributor Author

I would like to add a functional test to prove the bug and that my fix is working but I don't know how to do it:

  • May someone point me in the right direction with an existing functional test I can use as a base
  • Where should I put such a functional test in the repository? Is tests/Doctrine/Tests/ORM/Functional the right path? What should be the filename?

Thanks 🙏

@mpdude
Copy link
Contributor

mpdude commented May 31, 2023

Hey there 👋🏼,

I am actively working on major changes to the commit order computation. Could you please have a look at #10547 and/or try if the branch entity-level-commit-order (you can Composer-install it as dev-entity-level-commit-order!) solves the issues for you? If so, please leave a note in #10547.

@sylfabre
Copy link
Contributor Author

This PR is replaced by https://github.com/doctrine/orm/pull/10547/files

Thanks @mpdude

@sylfabre sylfabre closed this Jul 30, 2023
@sylfabre sylfabre deleted the bug_10715 branch July 30, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect subclasses dependencies weight while calculating commit orders
2 participants