Fixed the structure of the reverse-engineered mapping #1123
Conversation
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3278 We use Jira to track the state of pull requests and the versions they got |
|
@stof a lot of tests seem to fail due to undefined index |
|
Related: DDC-3277 |
|
|
||
| $this->assertArrayHasKey('columnDefault', $metadata->fieldMappings); | ||
| $this->assertEquals('test_default', $metadata->fieldMappings['columnDefault']['default']); | ||
| $this->assertEquals('test_default', $metadata->fieldMappings['columnDefault']['options']['default']); |
There was a problem hiding this comment.
@stof can you add another test for the fixed option?
There was a problem hiding this comment.
Well, I don't know exactly which platforms are supporting the fixed option for columns to test it
There was a problem hiding this comment.
@stof I added a documentation chapter in DBAL about type mappings some months ago. There you can see which platform supports it and which doesn't.
Looks like only Drizzle does not support distinction between fixed and variable string types.
Only because I add to do a separate commit to update them, as I did it through the web UI on github |
Fixed the structure of the reverse-engineered mapping
|
Test for |
when using the DatabaseDriver, the field mapping being generated does not match the field mapping expected by all other drivers or the SchemaTool. This means that these mapping settings get ignored.
See doctrine/migrations#184 for the initial report