Document embeddables column prefixing #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3292 We use Jira to track the state of pull requests and the versions they got |
|
|
||
| // Will name your columns by prefixing them with "prefix_" | ||
| // Your columns will be named as: | ||
| // "prefix_street", "prefix_postalCode" ... |
There was a problem hiding this comment.
Instead of putting comments in the code snippet, It would be better to have smaller snippets and the explanation outside the code. This would also avoid duplicating the explanation for each format
|
@stof Don't know if you guys are sent notifications or not, but I revised this per your instructions. |
|
@CRYBAT we don't get notifications for new commits, just for comments: so thanks for letting us know :-) |
|
@CRYBAT merging, thanks! |
Ocramius
added a commit
that referenced
this pull request
Sep 10, 2014
Document embeddables column prefixing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: https://groups.google.com/forum/#!topic/doctrine-user/xDiL65QV_sM
Documents column prefixing for embeddables. Adds headings.
I can't use XML or YAML configuration, so I'm not sure if those are correct.