Avoid prefixing columns when false is assigned to column-prefix
#1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3477 We use Jira to track the state of pull requests and the versions they got |
|
Looking good: 👍 @CentaurWarchief as usual, I have to ask for tests. EDIT: the fix is flawed for now. See inline comments |
| @@ -833,6 +842,6 @@ protected function evaluateBoolean($element) | |||
| { | |||
| $flag = (string)$element; | |||
|
|
|||
| return ($flag === true || $flag == "true" || $flag == "1"); | |||
There was a problem hiding this comment.
Why did you remove the simple boolean true case?
There was a problem hiding this comment.
Because (string) $element never will be true. They're different types.
$ php -r 'var_dump((string) 'true' === true);' // bool(false)
| : null; | ||
|
|
||
| $useColumnPrefix = isset($embeddedMapping['use-column-prefix']) | ||
| ? $this->evaluateBoolean( |
There was a problem hiding this comment.
No need for the line-wrap for the parameters here
Ocramius
added a commit
that referenced
this pull request
Jan 8, 2015
Ocramius
added a commit
that referenced
this pull request
Jan 8, 2015
…="true"` and `use-column-prefix="false"` xml mappings
Ocramius
added a commit
that referenced
this pull request
Jan 8, 2015
…pped-embeddables' Close #1238
|
@CentaurWarchief merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://www.doctrine-project.org/jira/browse/DDC-3293
As the issue on JIRA wasn't updated since September/2014, here's a PR.
@Ocramius suggested on issue about introducing a new attribute called
use-column-prefix, I'd say that keeping the same attribute as in others drivers would be better.That's it.